Re: [PATCH] arm64: KVM: Demote SVE and LORegion warnings to debug only

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 17, 2018 at 09:23:56AM +0100, Marc Zyngier wrote:
> While generating a message about guests probing for SVE/LORegions
> is a useful debugging tool, considering it an error is slightly
> over the top, as this is the only way the guest can find out
> about the presence of the feature.
> 
> Let's turn these message into kvm_debug so that they can only
> be seen if CONFIG_DYNAMIC_DEBUG, and kept quiet otherwise.
> 
> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>

Acked-by: Christoffer Dall <christoffer.dall@xxxxxxx>

> ---
>  arch/arm64/kvm/sys_regs.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
> index 806b0b126a64..6e3b969391fd 100644
> --- a/arch/arm64/kvm/sys_regs.c
> +++ b/arch/arm64/kvm/sys_regs.c
> @@ -996,14 +996,12 @@ static u64 read_id_reg(struct sys_reg_desc const *r, bool raz)
>  
>  	if (id == SYS_ID_AA64PFR0_EL1) {
>  		if (val & (0xfUL << ID_AA64PFR0_SVE_SHIFT))
> -			pr_err_once("kvm [%i]: SVE unsupported for guests, suppressing\n",
> -				    task_pid_nr(current));
> +			kvm_debug("SVE unsupported for guests, suppressing\n");
>  
>  		val &= ~(0xfUL << ID_AA64PFR0_SVE_SHIFT);
>  	} else if (id == SYS_ID_AA64MMFR1_EL1) {
>  		if (val & (0xfUL << ID_AA64MMFR1_LOR_SHIFT))
> -			pr_err_once("kvm [%i]: LORegions unsupported for guests, suppressing\n",
> -				    task_pid_nr(current));
> +			kvm_debug("LORegions unsupported for guests, suppressing\n");
>  
>  		val &= ~(0xfUL << ID_AA64MMFR1_LOR_SHIFT);
>  	}
> -- 
> 2.14.2
> 



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux