On Mon, 16 Apr 2018 15:13:59 +0200 Pierre Morel <pmorel@xxxxxxxxxxxxxxxxxx> wrote: > On 15/04/2018 23:22, Tony Krowiak wrote: > > +* Register with the ap_bus for AP queue devices of type CEX4, CEX5 and > > + CEX6 and to provide the vfio_ap driver's probe and remove callback interfaces. > > I wonder why the type of card has anything to do with this driver. > It should be transparent, the driver should be able to provide the > matrix (APM/AQM/ADM) > independently from the type of card in the slot. Would also be interested why this is limited to certain, newer cards. Did some kind of interface change (I dimly recall something like that), or are simply no old systems with those older card types around to check whether it works? In either case, a short note would be good (does not need to go into any details).