On 16/04/2018 14:09, Raslan, KarimAllah wrote: >> I assume the caching will also be a separate patch. > Yup, do you want me to include it in this one? I already have it, I > just thought that I get those bits out first. It's the same for me. Paolo >> It looks good except that I'd squash patches 4 and 9 together. > Yup, makes sense. I should have squashed them when I removed the > lifecycle change! > > Thanks for the review :) > >> But I'd like a second set of eyes to look at it.
