Re: [PATCH 13/23] x86/speculation: Use IBRS if available before calling into firmware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2018-04-16 20:32 GMT+02:00 Youquan Song <youquan.song@xxxxxxxxx>:
> From: David Woodhouse <dwmw@xxxxxxxxxxxx>
>
> (cherry picked from commit dd84441a797150dcc49298ec95c459a8891d8bb1)
>
> Retpoline means the kernel is safe because it has no indirect branches.
> But firmware isn't, so use IBRS for firmware calls if it's available.
>
> Block preemption while IBRS is set, although in practice the call sites
> already had to be doing that.
>
> Ignore hpwdt.c for now. It's taking spinlocks and calling into firmware
> code, from an NMI handler. I don't want to touch that with a bargepole.
>
> Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
> Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: arjan.van.de.ven@xxxxxxxxx
> Cc: bp@xxxxxxxxx
> Cc: dave.hansen@xxxxxxxxx
> Cc: jmattson@xxxxxxxxxx
> Cc: karahmed@xxxxxxxxx
> Cc: kvm@xxxxxxxxxxxxxxx
> Cc: pbonzini@xxxxxxxxxx
> Cc: rkrcmar@xxxxxxxxxx
> Link: http://lkml.kernel.org/r/1519037457-7643-2-git-send-email-dwmw@xxxxxxxxxxxx
> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> [Youquan Song: port to 4.4]
> Signed-off-by: Youquan Song <youquan.song@xxxxxxxxxxxxxxx>
Hi Youquan,

Thanks for doing this, do you have git tree for all these patches?

One suggestion, for stable patch you'd better cc to stable@xxxxxxxxxxxxxxx

Regards,
Jack



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux