Hi Geert, On Wed, Apr 11, 2018 at 10:39:19AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Apr 11, 2018 at 10:22 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > > On Tue, Apr 10, 2018 at 05:53:47PM +0200, Geert Uytterhoeven wrote: ... > >> @@ -217,6 +236,9 @@ static int vfio_platform_call_reset(struct vfio_platform_device *vdev, > >> } else if (vdev->of_reset) { > >> dev_info(vdev->device, "reset\n"); > >> return vdev->of_reset(vdev); > >> + } else if (vdev->reset_control) { > >> + dev_info(vdev->device, "reset\n"); > > > > Would it be useful to differentiate between the above two informational > > messages? > > Probably not, there's also no differentiation with the message for the > ACPI case above (out of visible context). Thanks, I agree that it seems fine to leave things as you have them above.