On 11/04/2018 14:06, Wanpeng Li wrote: >>>> Use kvm_fast_pio_in() on VMX and consolidate x86's fast PIO code >>>> now that both VMX and SVM support fast PIO for IN and OUT. >>> I found the kvm-unit-tests/emulator.flat fails after this patchset. >> The tests that are failing rely on KVM to use emulate_instruction for >> an IN instruction. Now that IN doesn't trigger emulation the tests >> fail. The unit tests are easily fixed by replacing IN with INSB. > Do you have any idea why fast pio can't handle IN? It can, but now the emulator does not run anymore. The test relies on "splitting" the iTLB and dTLB, to trick KVM into emulating an instruction other than IN, so the test fails. Paolo