On Mon, 2 Apr 2018 20:36:17 +0200 Alvise Rigo <a.rigo@xxxxxxxxxxxxxxxxxxxxxx> wrote: > Hello Alex, > > As I wrote in the other thread, it was OK by me to be reviewer. I > though only Eric needed to ACK this patch as new sub-maintainer. > > Is it too late for ACK-ing it now? > > Acked-by: Alvise Rigo <a.rigo@xxxxxxxxxxxxxxxxxxxxxx> Hi Alvise, Sorry, I consider that each person can really only ack for themselves for MAINTAINERS entries, I'm not going to sign-up anyone without their explicit approval, nor am I going to invent an Acked-by for a commit log based on an informal comment. This was also a little bit of a test, given that we have no history, I was hoping for a proactive review. It's too late for this patch, but you're welcome to submit a new patch adding yourself, preferably after some participation in this area. I'm not interested in adding entries only as tokens of company lineage, we have attributes in source files and commit logs for that. I do appreciate you making us aware of Baptiste's departure though so that we can keep these entries current. Thanks, Alex > On Mon, Apr 2, 2018 at 5:19 PM, Alex Williamson > <alex.williamson@xxxxxxxxxx> wrote: > > On Mon, 26 Mar 2018 13:42:02 -0600 > > Alex Williamson <alex.williamson@xxxxxxxxxx> wrote: > > > >> Baptiste has changed positions and has not been active with > >> vfio-platform, replace with the current, de-facto sub-maintainer > >> Eric Auger. Also add Alvise Rigo as a designated reviewer. > >> > >> Cc: Eric Auger <eric.auger@xxxxxxxxxx> > >> Cc: Alvise Rigo <a.rigo@xxxxxxxxxxxxxxxxxxxxxx> > >> Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx> > >> --- > >> MAINTAINERS | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index 205c8fc12a9c..c6680c189f2b 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -14687,7 +14687,8 @@ F: include/linux/mdev.h > >> F: samples/vfio-mdev/ > >> > >> VFIO PLATFORM DRIVER > >> -M: Baptiste Reynal <b.reynal@xxxxxxxxxxxxxxxxxxxxxx> > >> +M: Eric Auger <eric.auger@xxxxxxxxxx> > >> +R: Alvise Rigo <a.rigo@xxxxxxxxxxxxxxxxxxxxxx> > >> L: kvm@xxxxxxxxxxxxxxx > >> S: Maintained > >> F: drivers/vfio/platform/ > >> > > > > Receiving only Eric's review, I've committed this with only Eric's > > entry and an updated commit log to reflect that. Thanks, > > > > Alex
