On Thu, Mar 29, 2018 at 11:43:07AM +0800, Xiao Guangrong wrote:
>
>
> On 03/28/2018 05:42 PM, Peter Xu wrote:
> > On Tue, Mar 27, 2018 at 05:10:36PM +0800, guangrong.xiao@xxxxxxxxx wrote:
> >
> > [...]
> >
> > > +static int compress_threads_load_setup(void)
> > > +{
> > > + int i, thread_count;
> > > +
> > > + if (!migrate_use_compression()) {
> > > + return 0;
> > > + }
> > > +
> > > + thread_count = migrate_decompress_threads();
> > > + decompress_threads = g_new0(QemuThread, thread_count);
> > > + decomp_param = g_new0(DecompressParam, thread_count);
> > > + qemu_mutex_init(&decomp_done_lock);
> > > + qemu_cond_init(&decomp_done_cond);
> > > + for (i = 0; i < thread_count; i++) {
> > > + if (inflateInit(&decomp_param[i].stream) != Z_OK) {
> > > + goto exit;
> > > + }
> > > + decomp_param[i].stream.opaque = &decomp_param[i];
> >
> > Same question as the encoding patch here, otherwise looks good to me.
>
> Thanks for you pointed out, will fix.
>
> Hmm, can i treat it as your Reviewed-by for the next version?
Yes :), as long as we drop the usage of zstream.opaque and use any
existing fields.
And also for the previous patch too, since they are mostly the same.
Thanks,
--
Peter Xu
