> -----Original Message----- > From: Radim Krčmář <rkrcmar@xxxxxxxxxx> > Sent: Wednesday, March 28, 2018 3:27 PM > To: Moger, Babu <Babu.Moger@xxxxxxx> > Cc: joro@xxxxxxxxxx; tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; > hpa@xxxxxxxxx; x86@xxxxxxxxxx; pbonzini@xxxxxxxxxx; > kvm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 3/5] KVM: VMX: Bring the common code to header > file > > 2018-03-16 16:37-0400, Babu Moger: > > This patch brings some of the code from vmx to x86.h header file. Now, we > > can share this code between vmx and svm. Modified couple functions to > make > > it common. > > > > Signed-off-by: Babu Moger <babu.moger@xxxxxxx> > > --- > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > > @@ -6683,8 +6652,9 @@ static void shrink_ple_window(struct kvm_vcpu > *vcpu) > > struct vcpu_vmx *vmx = to_vmx(vcpu); > > int old = vmx->ple_window; > > > > - vmx->ple_window = __shrink_ple_window(old, > > - ple_window_shrink, ple_window); > > + vmx->ple_window = __shrink_ple_window(old, ple_window, > > + ple_window_shrink, > > + 0); > > I have preserved the old minumum (ple_window, so we could't get > uselessly small values). Ok. Looks good. Thanks