On Tue, Mar 27, 2018 at 08:33:22AM +0200, Michal Hocko wrote: > > > > + * The function itself might sleep so it cannot be called from atomic > > > > + * contexts. > > > I don't see how walk_free_mem_block() can sleep. > > > > OK, it would be better to remove this sentence for the current version. But > > I think we could probably keep it if we decide to add cond_resched() below. > > The point of this sentence was to make any user aware that the function > might sleep from the very begining rather than chase existing callers > when we need to add cond_resched or sleep for any other reason. So I > would rather keep it. Let's say what it is then - "will be changed to sleep in the future". > -- > Michal Hocko > SUSE Labs
