2018-03-27 15:25 GMT+08:00 Paolo Bonzini <pbonzini@xxxxxxxxxx>: > On 27/03/2018 07:18, Konrad Rzeszutek Wilk wrote: >>> I think a global module is enough for testing. >> If so, perhaps have it wrapped with #ifdef DEBUG? >> >> No need to put code gadgets that won't be utilized 99% of time. > > It is going to be used a lot in testing, actually. There are quite a > few emulate.c bugfixes that are hard to test (see for example the > syscall eflags.tf bug that can currently be tested only on Intel) and > having something like this can only improve our coverage. > > #ifdef DEBUG is almost always a bad idea, and though I agree that the > commit messages can be improved, I think the module parameter is the way > to go. > > Wanpeng, can you also add it to svm.c? Yeah, thanks for the review. :) Regards, Wanpeng Li
