Re: [kvm-unit-tests PATCH v2 6/8] s390x: Add cmm tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23.03.2018 14:51, David Hildenbrand wrote:
> On 20.03.2018 12:19, Janosch Frank wrote:
>> Collaborative Memory Management is the extended vm memory usage
>> hinting for the hypervisor and handling the ESSA instruction is quite
>> complicated. Let's add at least a bare-bones test, maybe someone will
>> extend it later.
>>
[...]
>> +uint16_t get_pgm_int_code(void)
>> +{
>> +	mb();
>> +	if (!lc->pgm_int_code)
>> +		pgm_int_expected = false;
> 
> Shouldn't this be if (lc->pgm_int_code) ... ?
> 
> Anyhow, can't you reuse clear_pgm_int() ? Should do what you need.

Yes, I can.
clear_pgm_int() wasn't yet available when I wrote the test though.

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux