Re: [PATCH 1/3] tools/kvm_stat: Fix python3 syntax

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23.03.2018 23:07, Cole Robinson wrote:
> $ python3 tools/kvm/kvm_stat/kvm_stat
>   File "tools/kvm/kvm_stat/kvm_stat", line 1137
>     def sortkey((_k, v)):
>                 ^
> SyntaxError: invalid syntax
> 
> Fix it in a way that's compatible with python2 and python3
> 
> Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx>
> ---
>  tools/kvm/kvm_stat/kvm_stat | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
> index 5898c22ba310..645d4bb69f5f 100755
> --- a/tools/kvm/kvm_stat/kvm_stat
> +++ b/tools/kvm/kvm_stat/kvm_stat
> @@ -1134,12 +1134,14 @@ class Tui(object):
>          def get_sorted_events(self, stats):
>              """ separate parent and child events """
>              if self._sorting == SORT_DEFAULT:
> -                def sortkey((_k, v)):
> +                def sortkey(pair):
>                      # sort by (delta value, overall value)
> +                    v = pair[1]
>                      return (v.delta, v.value)
>              else:
> -                def sortkey((_k, v)):
> +                def sortkey(pair):
>                      # sort by overall value
> +                    v = pair[1]
>                      return v.value
> 
>              childs = []
> 

Tested-by: Stefan Raspl <stefan.raspl@xxxxxxxxxxxxxxxxxx>




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux