On Wed, Jun 03, 2009 at 02:25:42PM -0400, Glauber Costa wrote: > @@ -407,12 +393,12 @@ static int kvm_main_loop_cpu(CPUState *env) > if (env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI)) > env->halted = 0; > if (!kvm_irqchip_in_kernel(kvm_context)) { > - if (env->kvm_cpu_state.init) > + if (apic_init_received(env)) > update_regs_for_init(env); > - if (env->kvm_cpu_state.sipi_needed) > + if (apic_sipi_needed(env)) > update_regs_for_sipi(env); > } > - if (!env->halted && !env->kvm_cpu_state.init) > + if (!env->halted) You remove checking of init here. Why? It looks like it can be safely removed, but can you do it as a separate patch with explanation why it is not needed here. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html