On 19/03/2018 08:31, Kang, Luwei wrote: >>> + if (pt_mode == PT_MODE_HOST_GUEST) { >> This would be vmx_pt_supported(), but I think it's better to remove that function and just test pt_mode == >> PT_MODE_HOST_GUEST everywhere (or !=). > Hi Paolo, > There have so many vmx_pt_supported() invoked in MSRs read/write (patch 9) patch and I think it can be replaced by pt_mode check. > But I think this function need to be reserved in patch 5(cpuid emulation). What is your opinion? Yes, the function pointer needs to stay. Paolo