On Sat, Mar 17, 2018 at 08:11:42AM -0700, Liran Alon wrote: > > ----- dan.carpenter@xxxxxxxxxx wrote: > > > "rep_done" is always zero so the "(((u64)rep_done & 0xfff) << 32)" > > expression is just zero. We can remove the "res" temporary variable > > as > > well and just use "ret" directly. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > I think this commit should better be dropped than applied. > The original code makes sense. It causes static checker warnings and kernel style says there shouldn't be code without a user. Plus we're not really deleting it, it's still there in the git log. regards, dan carpenter
