Re: [PATCH v4 kvmtool 10/12] vfio: Support non-mmappable regions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v4 kvmtool 10/12] vfio: Support non-mmappable regions
From: Jean-Philippe Brucker <jean-philippe.brucker@xxxxxxx>
Date: Wed, 14 Mar 2018 18:23:34 +0000
Cc: "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, Will Deacon <Will.Deacon@xxxxxxx>, Robin Murphy <Robin.Murphy@xxxxxxx>, Lorenzo Pieralisi <Lorenzo.Pieralisi@xxxxxxx>, Marc Zyngier <Marc.Zyngier@xxxxxxx>, "alex.williamson@xxxxxxxxxx" <alex.williamson@xxxxxxxxxx>
In-reply-to: <87tvti4krb.fsf@e105922-lin.cambridge.arm.com>
References: <20171122185823.7765-1-jean-philippe.brucker@arm.com> <20171122185823.7765-11-jean-philippe.brucker@arm.com> <87tvti4krb.fsf@e105922-lin.cambridge.arm.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 14/03/18 17:42, Punit Agrawal wrote:
>> +	region->vdev = vdev;
>> +	region->is_ioport = !!(bar & PCI_BASE_ADDRESS_SPACE_IO);
>>  	region->info = (struct vfio_region_info) {
>>  		.argsz = sizeof(*region),
> 
> sizeof(region->info)?

Woops, good catch

Thanks,
Jean

References:
- [PATCH v4 kvmtool 00/12] Add vfio-pci support
  - From: Jean-Philippe Brucker
- [PATCH v4 kvmtool 10/12] vfio: Support non-mmappable regions
  - From: Jean-Philippe Brucker
- Re: [PATCH v4 kvmtool 10/12] vfio: Support non-mmappable regions
  - From: Punit Agrawal

Prev by Date: Re: [PATCH v4 4/6] vfio/type1: check dma map request is within a valid iova range
Next by Date: Re: [PATCH v4 kvmtool 00/12] Add vfio-pci support
Previous by thread: Re: [PATCH v4 kvmtool 10/12] vfio: Support non-mmappable regions
Next by thread: [PATCH v4 kvmtool 04/12] Extend memory bank API with memory types
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]