On 14.03.2018 09:18, Janosch Frank wrote:
> On 13.03.2018 17:07, Thomas Huth wrote:
>> On 13.03.2018 13:01, Janosch Frank wrote:
>>> The Store Hypervisor Information (STHYI) instruction provides system
>>> information like available CPU resources on each system level. The
>>> instruction is fully emulated by the hypervisor.
[...]
>>> +
>>> +int main(void)
>>> +{
>>> + report_prefix_push("sthyi");
>>> +
>>> + /* Test for availability */
>>> + if (!test_facility(74))
>>> + goto exit;
>>
>> Could you maybe change this to something like:
>>
>> has_sthyi = test_facility(74);
>> report_xfail("STHYI available", !has_sthyi, has_sthyi);
>> if (!has_sthyi)
>> goto exit;
>>
>> ... so that the user sees at least something if the facility is not
>> available.
>
> Sure
>
>>
>>> + /* Test register/argument checking. */
>>> + test_exception_addr();
>>> + test_exception_reg_odd();
>>> + test_exception_reg_equal();
>>> + test_function_code((uint64_t) pagebuf);
>>> +
>>> + /* Test function code 0 - CP and IFL Capacity Information */
>>> + test_fcode0();
>>> +
>>> +exit:
>>
>> Maybe use a different label name? ... I'm normally trying to avoid to
>> use names that are part of the standard libc, e.g. the exit() function
>> in this case.
>
> Ok, will change for all patches in the series, how about:
> test_report:
Fine for me. Or maybe simply "done:" ?
>>> + report_prefix_pop();
>>> + return report_summary();
>>> +}
Thomas
Attachment:
signature.asc
Description: OpenPGP digital signature
