On Monday, 2018-03-12, Christopherson, Sean J <sean.j.christopherson@xxxxxxxxx> wrote: > On Friday, 2018-03-09, Radim Krčmář <rkrcmar@xxxxxxxxxx> wrote: > > 2018-03-05 12:04-0800, Sean Christopherson: > > > This series eliminates usage of legacy code that is obsolete when > > > unrestricted guest is enabled. > > > > > > Because unrestricted guest (Westmere) was introduced one generation > > > later than EPT (Nehalem), KVM's initial support for EPT by necessity > > > retained/introduced soon-to-be-legacy code for handling a guest with > > > EPT enabled and CR0.PG/PE==0. Some of this now-legacy code/behavior > > > wasn't correctly deprecated when KVM added support for unrestricted > > > guest, e.g. KVM still creates and loads identity mapped IA32 page > > > tables when the guest disables paging, even though CR0.PG is cleared > > > in hardware. > > > > Great series, added to kvm/queue, thanks! > > > > Have you checked the coverage of kvm-unit-tests? > > I have not, I'll look at it today. Verified coverage via gcov with unrestricted_guest enabled and disabled. The only affected code that isn't being exercised is the WARN_ON_ONCE in handle_cr for the read from CR3.
