Glauber Costa wrote: > This is not kvm specific, and should do fine in plain qemu This is fine with plain qemu already. The problem, IIUC, is that in-kernel kvm irqchip does not have a chance to remove the halted state again. Did you test the effect of this patch on that scenario? What makes it safe to be removed now? > > Signed-off-by: Glauber Costa <glommer@xxxxxxxxxx> > --- > hw/apic.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/hw/apic.c b/hw/apic.c > index 86aa6b6..2eddba0 100644 > --- a/hw/apic.c > +++ b/hw/apic.c > @@ -467,8 +467,7 @@ static void apic_init_ipi(APICState *s) > > cpu_reset(s->cpu_env); > > - if (!(s->apicbase & MSR_IA32_APICBASE_BSP) && > - (!kvm_enabled() || !qemu_kvm_irqchip_in_kernel())) > + if (!(s->apicbase & MSR_IA32_APICBASE_BSP)) > s->cpu_env->halted = 1; > > if (kvm_enabled() && !qemu_kvm_irqchip_in_kernel()) Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
