Re: [PATCH v10 26/28] qmp: add query-sev-capabilities command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/28/2018 03:10 PM, Brijesh Singh wrote:
The command can be used by libvirt to query the SEV capabilities.

Cc: "Daniel P. Berrangé" <berrange@xxxxxxxxxx>
Cc: "Dr. David Alan Gilbert" <dgilbert@xxxxxxxxxx>
Cc: Markus Armbruster <armbru@xxxxxxxxxx>
Signed-off-by: Brijesh Singh <brijesh.singh@xxxxxxx>
---
  monitor.c             |  7 +++++++
  qapi-schema.json      | 42 ++++++++++++++++++++++++++++++++++++++++++
  target/i386/monitor.c |  5 +++++
  3 files changed, 54 insertions(+)

And another rebase victim.


+##
+# @query-sev-capabilities:
+#
+# This command is used to get the SEV capabilities and supported on AMD

grammar suggestion: s/capabilities and/capabilities, and is/

+# X86 platform only.

s/platform/platforms/

+#
+# Returns: a list of SevCapability objects.

This says it returns a list of objects...

+#
+# Since: 2.12
+#
+# Example:
+#
+# -> { "execute": "query-sev-capabilities" }

...but this says it returns a single object.

+# <- { "return": { "pdh": "8CCDD8DDD", "cert-chain": "888CCCDDDEE",
+#                  "cbitpos": 47, "reduced-phys-bits": 5}}
+#
+##
+{ 'command': 'query-sev-capabilities', 'returns': 'SevCapability' }
diff --git a/target/i386/monitor.c b/target/i386/monitor.c
index 577d50eebaaa..1b55dd0fff88 100644
--- a/target/i386/monitor.c
+++ b/target/i386/monitor.c
@@ -737,3 +737,8 @@ SevLaunchMeasureInfo *qmp_query_sev_launch_measure(Error **errp)
return info;
  }
+
+SevCapability *qmp_query_sev_capabilities(Error **errp)
+{
+    return NULL;

Should call error_setg() before returning NULL.

+}


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux