> -----Original Message----- > From: Radim Krčmář [mailto:rkrcmar@xxxxxxxxxx] > Sent: Wednesday, February 28, 2018 11:38 AM > To: Moger, Babu <Babu.Moger@xxxxxxx> > Cc: pbonzini@xxxxxxxxxx; rth@xxxxxxxxxxx; ehabkost@xxxxxxxxxx; > mtosatti@xxxxxxxxxx; qemu-devel@xxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; > pixo@xxxxxxxxxxxx; Hook, Gary <Gary.Hook@xxxxxxx> > Subject: Re: [PATCH v2 1/5] target/i386: Fix a minor typo found while > reviwing > > 2018-02-23 21:30-0500, Babu Moger: > > Changed KVM_CPUID_FLAG_SIGNIFCANT_INDEX to > KVM_CPUID_FLAG_SIGNIFICANT_INDEX > > > > Signed-off-by: Babu Moger <babu.moger@xxxxxxx> > > --- > > linux-headers/asm-x86/kvm.h | 2 +- > > target/i386/kvm.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/linux-headers/asm-x86/kvm.h b/linux-headers/asm-x86/kvm.h > > index f3a9604..6aec661 100644 > > --- a/linux-headers/asm-x86/kvm.h > > +++ b/linux-headers/asm-x86/kvm.h > > @@ -220,7 +220,7 @@ struct kvm_cpuid_entry2 { > > __u32 padding[3]; > > }; > > > > -#define KVM_CPUID_FLAG_SIGNIFCANT_INDEX (1 << 0) > > The typo is in the original kernel header and we periodically copy it > over with scripts/update-linux-headers.sh, so this change would only add > overhead in the long run. Yes. I see that now. > > I'd keep the typo. Sure. I will drop this patch. Let me not complicate things. > > (The alternative is to add KVM_CPUID_FLAG_SIGNIFICANT_INDEX to the > linux > header, so there would be both variants and use the correct one here.) > > Thanks. > > > +#define KVM_CPUID_FLAG_SIGNIFICANT_INDEX (1 << 0) > > #define KVM_CPUID_FLAG_STATEFUL_FUNC (1 << 1) > > #define KVM_CPUID_FLAG_STATE_READ_NEXT (1 << 2) > > > > diff --git a/target/i386/kvm.c b/target/i386/kvm.c > > index ad4b159..85856b6 100644 > > --- a/target/i386/kvm.c > > +++ b/target/i386/kvm.c > > @@ -844,7 +844,7 @@ int kvm_arch_init_vcpu(CPUState *cs) > > break; > > } > > c->function = i; > > - c->flags = KVM_CPUID_FLAG_SIGNIFCANT_INDEX; > > + c->flags = KVM_CPUID_FLAG_SIGNIFICANT_INDEX; > > c->index = j; > > cpu_x86_cpuid(env, i, j, &c->eax, &c->ebx, &c->ecx, &c->edx); > > > > -- > > 1.8.3.1 > >
