Re: [PATCH 3/3] KVM: Cache pdptrs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Avi Kivity wrote:
+
 static void svm_set_vintr(struct vcpu_svm *svm)
 {
     svm->vmcb->control.intercept |= 1ULL << INTERCEPT_VINTR;
@@ -2286,12 +2298,6 @@ static int handle_exit(struct kvm_run *kvm_run, struct kvm_vcpu *vcpu)
         }
         vcpu->arch.cr0 = svm->vmcb->save.cr0;
         vcpu->arch.cr3 = svm->vmcb->save.cr3;
-        if (is_paging(vcpu) && is_pae(vcpu) && !is_long_mode(vcpu)) {
-            if (!load_pdptrs(vcpu, vcpu->arch.cr3)) {
-                kvm_inject_gp(vcpu, 0);
-                return 1;
-            }
-        }

... as done here.

That's a bug... luckily no guests trash their PDPTs after loading CR3.

I guess I should fix in a separate patch to avoid mixing a bugfix with a feature.


That could cause a regression if we catch a guest preparing a new pdpte. So I'll leave the code as is.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux