[PATCH v3 0/7] tools/kvm_stat improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Some bugfixes (patches 1&2), simplifications (patch 4), plus rework that
lays the basis for introducing a (hopefully) neater drilldown mode in
patch 6.
Note that in absence of any knowledge of the interdependencies of the
events in debugfs on other platforms like x86, this new 'functionality'
was only added for S390 for now. Adding other platforms would be easy
enough, though.
Furthermore note that the data passing between Providers and Stats is
pretty much at its limit now - if we'd ever wanted to put in more
attributes along with the event data passed from Providers to Stats, we
should probably switch to passing more involved data structures with
indicator flags, etc. Not sure if performance is a concern, but from a
coding/maintaining point of view that's something we should consider in
that case.


Changes in v3:
* Dropped patch "tools/kvm_stat: cache compiled regular expression"
* Added 2 new bugfixes (patch [1] + [2])
* Patch [5]: Fixed log and batch mode output to display the unique part
  of the keys, and not the included parent event

Changes in v2:
* Patch [1]:
   - Switched to single underscore prefixing for "private"
     methods.
* Patch [4]:
   - Renamed methods to "tracepoint_is_child" and "debugfs_is_child"
     from "trc_is_child" et al.
   - Also, moved "child_events" and "pid" from DebugfsProvider and
     TracepointProvider up to "Provider".


Stefan Raspl (7):
  tools/kvm_stat: fix debugfs handling
  tools/kvm_stat: fix logging mode
  tools/kvm_stat: mark private methods as such
  tools/kvm_stat: eliminate extra guest/pid selection dialog
  tools/kvm_stat: separate drilldown and fields filtering
  tools/kvm_stat: group child events indented after parent
  tools/kvm_stat: print 'Total' line for multiple events only

 tools/kvm/kvm_stat/kvm_stat     | 475 +++++++++++++++++++++++-----------------
 tools/kvm/kvm_stat/kvm_stat.txt |   4 +-
 2 files changed, 271 insertions(+), 208 deletions(-)

-- 
2.13.5




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux