On Thu, 15 Feb 2018 21:03:27 +0000, Christoffer Dall wrote: > > There is really no need to store the vgic_elrsr on the VGIC data > structures as the only need we have for the elrsr is to figure out if an > LR is inactive when we save the VGIC state upon returning from the > guest. We can might as well store this in a temporary local variable. > > This also gets rid of the endianness conversion in the VGIC save > function, which is completely unnecessary and would actually result in > incorrect functionality on big-endian systems, because we are only using > typed values here and not converting pointers and reading different > types here. > > Signed-off-by: Christoffer Dall <christoffer.dall@xxxxxxxxxx> Reviewed-by: Marc Zyngier <marc.zyngier@xxxxxxx> M. -- Jazz is not dead, it just smell funny.