On Wed, Feb 14, 2018 at 02:25:07PM +0100, Paolo Bonzini wrote: > On 14/02/2018 13:38, Andrew Jones wrote: > > Precisely, although I'm not sure it needs its own file. Since it might be > > nice to eventually clean up (remove?) libcflat.h, maybe we should create > > lib/stdio.[ch] and lib/stdlib.[ch] files. Implementations for libc > > functions (like getchar), that have their prototypes in lib/stdio.h, could > > all get thrown together in lib/stdio.c. > > > > Could be nice to define EOF in lib/stdio.h too. > > Yes, I agree on all accounts! > OK, I'll send a libc-ifying clean up series and then rebase patches 5-8 of this series on that series. Thanks, drew