On 11/02/2018 10:01, Liran Alon wrote: >> @@ -1615,6 +1621,12 @@ static int interrupt_exit_handler(void) >> case 6: >> vmcs_write(GUEST_ACTV_STATE, ACTV_HLT); >> break; >> + >> + case 8: >> + vmcs_write(GUEST_ACTV_STATE, ACTV_HLT); >> + vmcs_write(ENT_INTR_INFO, >> + TIMER_VECTOR | INTR_INFO_VALID_MASK); > > I would specify interrupt-type explicitly rather than implicitly. > Meaning passing here: > (TIMER_VECTOR | > (VMX_INTR_TYPE_EXT_INTR << INTR_INFO_INTR_TYPE_SHIFT) | > INTR_INFO_VALID_MASK) Agreed. Thanks for the review! Paolo >> + break; >> } >> vmx_inc_test_stage(); >> vmcs_write(GUEST_RIP, guest_rip + insn_len); >> -- >> 1.9.1 > > Besides small comment above, looks good to me. > Reviewed-by: Liran Alon <liran.alon@xxxxxxxxxx> >
