Avi Kivity wrote: > Jes Sorensen wrote: >> Ok, >> >> Trying once more. After spending a couple of hours trying to follow >> the QEMU dma codeflow, I have convinced myself Avi is right and those >> two functions don't need to do the flushing as they all end up >> calling dma_bdrv_cb() which calls dma_brdv_unmap(). I have added a >> couple comments to the code, which will hopefully save the next >> person the 'pleasure' of trying to figure out this too. >> > > It looks right to me. Xiantao? Fine to me. But seems the change in qemu_iovec_from_buffer is lost in this patch or that change is also not unnecessary ? Xiantao >> access_len -= l; >> - } >> + } >> + dma_flush_range((unsigned long)buffer, >> + (unsigned long)buffer + flush_len); >> } >> > > Detab your code, please. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
