On 05/02/2018 13:59, Stefan Raspl wrote: > Some bugfixes (patches 1&2), simplifications (patch 4), plus rework that > lays the basis for introducing a (hopefully) neater drilldown mode in > patch 7. > Note that in absence of any knowledge of the interdependencies of the > events in debugfs on other platforms like x86, this new 'functionality' > was only added for S390 for now. Adding other platforms would be easy > enough, though. > Furthermore note that the data passing between Providers and Stats is > pretty much at its limit now - if we'd ever wanted to put in more > attributes along with the event data passed from Providers to Stats, we > should probably switch to passing more involved data structures with > indicator flags, etc. Not sure if performance is a concern, but from a > coding/maintaining point of view that's something we should consider in > that case. > > > Stefan Raspl (8): > tools/kvm_stat: fix crash when filtering out all non-child trace > events > tools/kvm_stat: print error on invalid regex > tools/kvm_stat: mark private methods as such > tools/kvm_stat: eliminate extra guest/pid selection dialog > tools/kvm_stat: cache compiled regular expression > tools/kvm_stat: separate drilldown and fields filtering > tools/kvm_stat: group child events indented after parent > tools/kvm_stat: print 'Total' line for multiple events only > > tools/kvm/kvm_stat/kvm_stat | 438 +++++++++++++++++++++++----------------- > tools/kvm/kvm_stat/kvm_stat.txt | 4 +- > 2 files changed, 251 insertions(+), 191 deletions(-) > Looks good, just a few remarks on patch 3 and 6. I queued already the first two. Thanks! Paolo
