Re: [RFC/PATCH v3 02/16] s390/mm: Abstract gmap notify bit setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13.02.2018 15:10, David Hildenbrand wrote:
> On 09.02.2018 10:34, Janosch Frank wrote:
>> Currently we use the software PGSTE bits PGSTE_IN_BIT and PGSTE_VSIE_BIT
>> to notify before an invalidation occurs on a prefix page or a VSIE page
>> respectively. Both bits only work for a PGSTE, which only exists for
>> page tables.
>>
>> For huge page support we also need such bits for segments (pmds) so
>> let's introduce abstract GMAP_NOTIFY_* bits that will be realized into
>> the respective bits when gmap DAT table entries are protected.
> 
> This comment is stale.

Yes, I'm currently polishing. This version gives an impression how the
series looks like after shuffling it.
Correct comments have not been a priority yet, but I take every hint I get.

> 
> This patch is no longer needed but also doesn't hurt.

I kept this patch, as I disliked the PGSTE constants being used for
notification requests. I wouldn't have a lot of hard feelings dropping it.

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux