On Fri, Feb 9, 2018 at 3:41 PM, KarimAllah Ahmed <karahmed@xxxxxxxxxx> wrote: > I assume you are referring to this: > > https://patchwork.kernel.org/patch/10194819/ > > .. which is now: > > commit 904e14fb7cb9 ("KVM: VMX: make MSR bitmaps per-VCPU") > > right? > > If this is the case, then I do not see where the MSR_BITMAP is being > updated here. In fact, would not this be the commit that actually broke > it? I'm referring to <1517938181-15317-6-git-send-email-dwmw@xxxxxxxxxxxx>, which has: @@ -10043,6 +9954,9 @@ static void prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12) if (kvm_has_tsc_control) decache_tsc_multiplier(vmx); + if (cpu_has_vmx_msr_bitmap()) + vmcs_write64(MSR_BITMAP, __pa(vmx->nested.vmcs02.msr_bitmap)); + if (enable_vpid) { /* * There is no direct mapping between vpid02 and vpid12, the
