Marcelo Tosatti wrote: > On Thu, May 14, 2009 at 10:43:05PM +0200, Jan Kiszka wrote: >> When using the in-kernel PIT the speaker emulation has to synchronize >> the PIT state with KVM. Enhance the existing speaker sound device and >> allow it to take over port 0x61 by using KVM_CREATE_PIT2 where >> available. This unbreaks -soundhw pcspk in KVM mode. >> >> Changes in v4: >> - preserve full PIT state across read-modify-write >> - update kvm.h >> >> Changes in v3: >> - re-added incorrectly dropped kvm_enabled checks >> >> Changes in v2: >> - rebased over qemu-kvm and KVM_CREATE_PIT2 >> - refactored hooks in pcspk >> >> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx> > > Jan, > > You always attempt to use KVM_CREATE_PIT2, so say on migration if the > destination does not support the new ioctl you fallback to in-kernel > dummy naturally. Seems the right thing to do. > > Would be nice to avoid sprinkling KVM details inside hw/pcspk.c though > but that is another problem. Does this remark prevent merging the patch ATM? I do not see another way how to make the pcspk aware of the in-kernel PIT, given that the speaker is naturally coupled to PIT channel 2. > > Looks good (and v3 kernel patch). > Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
