On Tue, Jan 30, 2018 at 10:28:34AM -0800, Ken Hofsass wrote: > Thanks for looking at this Radim, > > On Tue, Jan 30, 2018 at 8:09 AM, Radim Krčmář <rkrcmar@xxxxxxxxxx> wrote: > > 2018-01-25 10:48-0800, Ken Hofsass: > >> Test framework for KVM and the Linux kernel that enables standalone > > .... > > This email didn't make it to the kvm list. Might be because it is too > > big, please see what the server said and potentially resend after > > splitting into parts, thanks. > > OK. The gtests framework code doesn't readily break into smaller > functionally independent patches. I will break it into patches that > separately add the large files and then have the last patch update the > Makefiles/etc, so the project still builds after each patch. (If > that's not acceptable, please recommend an alternative.) > > > (Also, doesn't compile here due to missing #include <asm/msr-index.h> > > and I didn't look further.) > > My apologies. Please try "KERNEL=<kernel-srcdir> make" > > The gtests code needs the actual KVM/kernel headers for the API/ABI > details. I should have added a check for $KERNEL before building > gtests. If you have a different recommendation for referencing the > kernel sources from the kvm-unit-test directory, let me know. > We've been copying the kernel files we need (see lib/linux/), or even just cherry-picking the defines we need from linux headers and dropping them into their respective kvm-unit-tests' lib/$ARCH/asm/ headers. Is there some reason you've opted not to do that? On a historical note, kvm-unit-tests used to look in kernel sources for headers, but we decided it would be more useful for the test suite to remove the dependency. That was pre 'make standalone' though. We could start a discussion about how much we need kvm-unit-tests to _build_ without the dependency now, as one can always build standalone tests on a build machine and then easily copy them to test machines. Thanks, drew
