On 29/01/2018 19:25, KarimAllah Ahmed wrote: >>> + case MSR_IA32_ARCH_CAPABILITIES: >>> + if (!msr_info->host_initiated) >>> + return 1; >>> + vmx->arch_capabilities = data; >>> + break; >> >> arch capabilities is read only. You don't need the set_msr handling >> for this. > > This is only for host driven writes. This would allow QEMU/whatever to > override the default value (i.e. the value from the hardware). Agreed. Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>