On Thu, 25 Jan 2018 14:28:45 +0100 Christian Borntraeger <borntraeger@xxxxxxxxxx> wrote: > From: Michael Mueller <mimu@xxxxxxxxxxxxxxxxxx> > > The function returns a pending I/O interrupt with the highest > priority defined by its ISC. > > Together with AIV activation, pending adapter interrupts are > managed by the GISA IPM. Thus kvm_s390_get_io_int() needs to > inspect the IPM as well when the interrupt with the highest > priority has to be identified. > > In case classic and adapter interrupts with the same ISC are > pending, the classic interrupt will be returned first. Can this lead to starving? Consider a guest that never enables itself for I/O interrupts, but collects pending interrupts via tpi. It will always get the intis for an isc, but not the ai, wouldn't it? > > Signed-off-by: Michael Mueller <mimu@xxxxxxxxxxxxxxxxxx> > Reviewed-by: Halil Pasic <pasic@xxxxxxxxxxxxxxxxxx> > Reviewed-by: Christian Borntraeger <borntraeger@xxxxxxxxxx> > Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx> > --- > arch/s390/kvm/interrupt.c | 71 +++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 65 insertions(+), 6 deletions(-)