Re: [PATCH 1/2] KVM: s390: add vcpu stat counters for many instruction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 01/24/2018 01:27 PM, Janosch Frank wrote:
> On 24.01.2018 12:32, Christian Borntraeger wrote:
>> The overall instruction counter is larger than the sum of the
>> single counters. We should try to catch all instruction handlers
>> to make this match the summary counter.
>> Let us add sck,tb,sske,iske,rrbe,tb,tpi,tsch,lpsw,pswe.....
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> 
> Acked-by: Janosch Frank <frankja@xxxxxxxxxxxxxxxxxx>

Thanks
> 
> [...]
>>
>>  static int handle_io_inst(struct kvm_vcpu *vcpu)
>>  {
>> +
>>  	VCPU_EVENT(vcpu, 4, "%s", "I/O instruction");
> 
> Whitespace damage

fixed.

> 
>>
>>  	if (vcpu->arch.sie_block->gpsw.mask & PSW_MASK_PSTATE)
>> @@ -527,6 +545,7 @@ static int handle_io_inst(struct kvm_vcpu *vcpu)
>>  		if (vcpu->arch.sie_block->ipa == 0xb235)
>>  			return handle_tsch(vcpu);
>>  		/* Handle in userspace. */
>> +		vcpu->stat.instruction_io++;
>>  		return -EOPNOTSUPP;
>>  	} else {
>>  		/*
> 




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux