Christoph Hellwig wrote:
This looks functionally correct, but pretty far from normal kernel coding
style.
I tend to avoid 'goto's.
Christoph Hellwig wrote:
/*
* IDE-compatible identify ioctl.
*
* Currenlyt only returns the serial number and leaves all other fields
* zero.
*/
Btw, thinking about it the rest of the information in the ioctl should
probably be filled up with faked data, similar to how we do it for
the ide emulation inside qemu.
Doing so crossed my mind but thought it may be better to
start here and provide data on an as-needed basis. But
as you point out there is precedent (and likely reason)
for hw/ide.c:ide_identify() doing as such. I don't have
a strong bias either way. Comments from others?
-john
--
john.cooper@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
