Looks good to me. In a couple of places you have spaces beforing the opening brace as in: + memcpy(&blkcfg.serial, s->serial_str, sizeof (blkcfg.serial)); which is not the style used in the surrounding code, I'd suggest removing them. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html