On 12.01.2018 11:10, Paolo Bonzini wrote: > On 10/01/2018 22:53, David Hildenbrand wrote: >> @@ -26,6 +26,7 @@ static uint64_t ram_size; >> static void mem_init(phys_addr_t freemem_start, phys_addr_t mem_end) >> { >> phys_alloc_init(freemem_start, ram_size - freemem_start); >> + setup_vm(); >> } >> >> void sclp_memory_setup(void) > > I'd leave setup_vm() to tests if not strictly necessary. > > Paolo > Makes handling of program exceptions unnecessary complicated. (which functions we're allowed to call etc.) And DAT can be easily disabled in tests that require it instead. So as long as there is no good reason for it, I prefer to keep it simple and always set it up. -- Thanks, David / dhildenb