>> +#include <libcflat.h> >> +#include <asm/page.h> >> +#include <asm/arch_def.h> >> +#include "sclp.h" >> + >> +static char _sccb[PAGE_SIZE] __attribute__((__aligned__(4096))); > > Could we maybe re-use the sccb buffer from sclp-write.c ? We can do that, we just have to make sure that later on with multiple CPUs, we don't call sclp functions at the same time (we could later use a lock or locally allocate a page). I assume secondary CPUs (e.g. SIGP tests I am working on) will not print to console / use SCLP. > > Maybe it would also make sense to merge sclp-write.c with sclp.c ? I want to keep this separate for now because a) I'll be introducing CPU + feature detection via sclp soon b) I might be introducing printing also to linemode console soon Especially b) can also be added to the pc-bios first. As we copied the file from QEMU this makes it easier to sync changes. Thanks! > > Thomas > -- Thanks, David / dhildenb
