On 11.01.2018 09:57, Thomas Huth wrote: > On 10.01.2018 22:53, David Hildenbrand wrote: >> Without the UL, we get 32 bit addresses, resulting in different memory >> addresses. This is necessary for enabling the MMU. >> >> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> >> --- >> s390x/intercept.c | 10 +++++----- >> s390x/selftest.c | 2 +- >> 2 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/s390x/intercept.c b/s390x/intercept.c >> index 99dde0d..b6027b2 100644 >> --- a/s390x/intercept.c >> +++ b/s390x/intercept.c >> @@ -46,7 +46,7 @@ static void test_stpx(void) >> check_pgm_int_code(PGM_INT_CODE_SPECIFICATION); >> >> expect_pgm_int(); >> - asm volatile(" stpx 0(%0) " : : "r"(-8)); >> + asm volatile(" stpx 0(%0) " : : "r"(-8UL)); > > I think I'd slightly prefer just "L" as suffix instead of "UL" ... in > practice, I guess it does not matter here though, so: > > Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx> > Will change, thanks! -- Thanks, David / dhildenb