On 11/01/2018 16:16, Thomas Huth wrote: > On 11.01.2018 15:00, Paolo Bonzini wrote: >> On 11/01/2018 11:29, Thomas Huth wrote: >>>> + /* leave another extra page free */ >>>> + freemem_start = ((phys_addr_t)&stacktop + PAGE_SIZE) & PAGE_MASK; >>> <bikeshedpainting> >>> I think I'd rather move that above line into mem_init() instead... >>> </bikeshedpainting> >> >> Also say why. :) > > The calculation does not really belong to the other stuff of > sclp_memory_setup(). And you then also you don't need that freemem_start > variable in sclp_memory_setup() anymore. Sorry, say why another page should be free... Paolo
