On 10.01.2018 22:53, David Hildenbrand wrote: > Copy all missing definitions from QEMU (include/hw/s390x/sclp.h). > We cannot simply replace the file, as some ASCII definitions are missing > in the QEMU file (defined somewhere else in QEMU). So this is is now a mixture from QEMU's pc-bios/s390-ccw/sclp.h and include/hw/s390x/sclp.h files? ... I think we should maybe state that in the header comment... > Convert QEMU_PACKED accordingly and copy the copyright statement. > > Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> > --- > lib/s390x/sclp.h | 107 ++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 106 insertions(+), 1 deletion(-) > > diff --git a/lib/s390x/sclp.h b/lib/s390x/sclp.h > index 3f4c138..000cbb7 100644 > --- a/lib/s390x/sclp.h > +++ b/lib/s390x/sclp.h > @@ -1,8 +1,13 @@ > /* > - * SCLP ASCII access driver > + * SCLP definitions > * > + * Copyright IBM, Corp. 2012 > * Copyright (c) 2013 Alexander Graf <agraf@xxxxxxx> > * > + * Authors: > + * Christian Borntraeger <borntraeger@xxxxxxxxxx> > + * Alexander Graf <agraf@xxxxxxx>$ The "$" is certainly wrong. I think I'd maybe rather write it like this: /* * SCLP definitions * * Based on the file pc-bios/s390-ccw/sclp.h from QEMU * Copyright (c) 2013 Alexander Graf <agraf@xxxxxxx> * * and based on the file include/hw/s390x/sclp.h from QEMU * Copyright IBM, Corp. 2012 * Author: Christian Borntraeger <borntraeger@xxxxxxxxxx> * * This work is licensed under the terms of the GNU GPL, version 2 or (at * your option) any later version. See the COPYING file in the top-level * directory. */ Thomas
