Re: [PATCH v2] KVM: s390: cleanup struct kvm_s390_float_interrupt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 10 Jan 2018 12:56:15 +0100
David Hildenbrand <david@xxxxxxxxxx> wrote:

> On 10.01.2018 12:30, Christian Borntraeger wrote:
> > 
> > 
> > On 01/08/2018 08:37 PM, David Hildenbrand wrote:  
> >> "wq" is not used at all. "cpuflags" can be access directly via the vcpu,
> >> just as "float_int" via vcpu->kvm.  
> > 
> > you also use the _set_cpuflag wrapper in several places, please add that to the patch description.
> > Otherwise this looks like a nice cleanup.  
> 
> Can you add that to the patch description when applying, if there are no
> other comments?
> 
> "While at it, reuse _set_cpuflag() to make the code look nicer.".
> 
> Thanks!
> 

With that, feel free to add

Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux