On Tue, Jan 09, 2018 at 07:54:29PM +0100, Andrew Jones wrote: > GICR_ICACTIVER0 (aka GICD_ICACTIVER) is based of the SGI_base, > not the RD_base. > > Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx> > --- > arm/gic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arm/gic.c b/arm/gic.c > index a945f7ab8385..5dd958e8b66b 100644 > --- a/arm/gic.c > +++ b/arm/gic.c > @@ -274,7 +274,7 @@ static void ipi_clear_active_handler(struct pt_regs *regs __unused) > if (gic_version() == 2) > base = gicv2_dist_base(); > else > - base = gicv3_redist_base(); > + base = gicv3_sgi_base(); Shouldn't this be: if (gic_version() == 2) base = gicv2_dist_base(); else if (irqnr < GIC_NR_PRIVATE_IRQS) base = gicv3_sgi_base(); else base = gicv3_dist_base(); Which would support all IRQs ? Thanks, -Christoffer > > writel(val, base + GICD_ICACTIVER); > > -- > 2.13.6 >
