On 21/12/2017 12:19, Aliaksei Karaliou wrote: > kvm_mmu_module_init() does not check result of register_shrinker() > which was tagged as __must_check recently, reported by sparse. > > Signed-off-by: Aliaksei Karaliou <akaraliou.dev@xxxxxxxxx> > --- > arch/x86/kvm/mmu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index 89da688..917ffaf 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -5482,10 +5482,13 @@ int kvm_mmu_module_init(void) > if (percpu_counter_init(&kvm_total_used_mmu_pages, 0, GFP_KERNEL)) > goto nomem; > > - register_shrinker(&mmu_shrinker); > + if (register_shrinker(&mmu_shrinker)) > + goto nomem_free_counter; > > return 0; > > +nomem_free_counter: > + percpu_counter_destroy(&kvm_total_used_mmu_pages); > nomem: > mmu_destroy_caches(); > return -ENOMEM; > Hi, I think a similar patch has already been queued by Andrew Morton. Thanks, Paolo
