On 15/12/2017 16:55, Juergen Gross wrote: > I'm fine with the general idea. > > I'm wondering whether you really want to require CONFIG_XEN for the > KVM case, though. > > Wouldn't it be better to rename arch/x86/xen/enlighten_pvh.c to > arch/x86/pvh.c and arch/x86/xen/xen-pvh.S to arch/x86/pvh-head.S, Yes, sounds good. > put both under CONFIG_PVH umbrella and select this from CONFIG_XEN_PVH > and KVM_PVH (or what you like to call it)? CONFIG_KVM_GUEST will be good enough. > In the two moved source files you can make Xen/KVM-specific parts > optional via their CONFIG_ options. > > And you might want to add an own ELF note for the KVM case? As long as it's compatible with Xen, it's not needed. Only the startup code changes between a KVM "PVH" kernel and a KVM "HVM" kernel. Paolo
