Michael S. Tsirkin wrote:
On Tue, May 26, 2009 at 11:33:37AM +0900, Isaku Yamahata wrote:
On Mon, May 25, 2009 at 03:25:33PM +0300, Michael S. Tsirkin wrote:
Add inline routines for convenient access to pci devices
with correct (little) endianness. Will be used by MSI-X support.
Just a minor comment.
How about to add pci_[sg]et_byte() for consistency?
I don't see that it makes sense - pci_set_long(config, value)
is shorter than *((uint32_t *)config) = cpu_to_le32(value),
but single bytes don't have endianness, and *config = value
is shorter.
It's nice to have consistent APIs though.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
