On Mon, Dec 11, 2017 at 02:49:19PM +0000, Marc Zyngier wrote: > asm-offsets.h contains a few DMA related definitions that have > the exact same name than the enum members they are derived from. > > While this is not a problem so far, it will become an issue if > both asm-offsets.h and include/linux/dma-direction.h: are pulled > by the same file. Umm. asm-offsets.h is only supposed to be included by assembly files. Assembly files would not be able to include linux/dma-direction.h So this shouldn't be a problem. The same could be true of things like CLOCK_REALTIME etc. Just don't do it. Keep asm-offsets.h as something that gets included by assembly and only assembly. If you need to know the offset of some member, use offsetof(), don't re-use asm-offsets.h. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up
