----- "Avi Kivity" <avi@xxxxxxxxxx> wrote:
> Michael Goldish wrote:
> > Signed-off-by: Michael Goldish <mgoldish@xxxxxxxxxx>
> > ---
> > client/tests/kvm_runtest_2/kvm_vm.py | 18 ++++++++++++++++++
> > 1 files changed, 18 insertions(+), 0 deletions(-)
> >
> > diff --git a/client/tests/kvm_runtest_2/kvm_vm.py
> b/client/tests/kvm_runtest_2/kvm_vm.py
> > index af06693..9571a3b 100644
> > --- a/client/tests/kvm_runtest_2/kvm_vm.py
> > +++ b/client/tests/kvm_runtest_2/kvm_vm.py
> > @@ -115,6 +115,24 @@ class VM:
> > if not os.path.exists(self.monitor_file_name):
> > break
> >
> > + def clone(self, name=None, params=None, qemu_path=None,
> image_dir=None, iso_dir=None):
> > + """Return a clone of the VM object with optionally modified
> parameters.
> > +
> > + The clone is initially not alive and needs to be started
> using create().
> > + Any parameters not passed to this function are copied from
> the source VM.
> > + """
> > + if name == None:
> > + name = self.name
> > + if params == None:
> > + params = self.params.copy()
> > + if qemu_path == None:
> > + qemu_path = self.qemu_path
> > + if image_dir == None:
> > + image_dir = self.image_dir
> > + if iso_dir == None:
> > + iso_dir = self.iso_dir
> > + return VM(name, params, qemu_path, image_dir, iso_dir)
> > +
> >
>
> return VM(name or self.name, params or self.params.copy(), ...)
That's much nicer, but it doesn't allow name to be "" and doesn't allow
params to be {}. It was once common for name to be "". I'm not sure
there's a good reason to allow for it now.
In any case, the shorter syntax can be used for the other parameters.
I used '== None' for all of them just to be consistent.
> --
> error compiling committee.c: too many arguments to function
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
